Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api endpoint to render request payloads for querying the LIQUID api #594

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add api endpoint to render request payloads for querying the LIQUID api #594

merged 1 commit into from
Nov 8, 2024

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented Nov 5, 2024

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
  • I updated the documentation to describe the semantical or interface changes I introduced.

@coveralls
Copy link

coveralls commented Nov 5, 2024 •
edited
Loading

Coverage Status

coverage: 79.018% (+0.2%) from 78.845%
when pulling c64fc2c on limes-test-tooling-for-LIQUID
into e83bd33 on master.

@Varsius Varsius force-pushed the limes-test-tooling-for-LIQUID branch from 1434463 to 22574e8 Compare November 5, 2024 10:33
@Varsius Varsius marked this pull request as ready for review November 5, 2024 10:37
majewsky
majewsky requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good already, but I have some concerns about the interface declaration and the mocks.

internal/test/plugins/capacity_static.go Outdated Show resolved Hide resolved
internal/test/plugins/quota_generic.go Outdated Show resolved Hide resolved
internal/core/plugin.go Outdated Show resolved Hide resolved
@Varsius Varsius force-pushed the limes-test-tooling-for-LIQUID branch from 22574e8 to 590a2de Compare November 7, 2024 08:43
majewsky
majewsky reviewed Nov 8, 2024
View reviewed changes
internal/api/liquid.go Outdated Show resolved Hide resolved
@Varsius Varsius force-pushed the limes-test-tooling-for-LIQUID branch from 590a2de to c64fc2c Compare November 8, 2024 14:21
majewsky
majewsky approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@majewsky majewsky merged commit 4107927 into master Nov 8, 2024
7 checks passed
@majewsky majewsky deleted the limes-test-tooling-for-LIQUID branch November 8, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varsius @coveralls @majewsky